Fix UsesType precondition pattern in KotlinTestMethodsShouldReturnUnit#1022
Merged
Conversation
UsesType matches against fully qualified type names, but the precondition was given the two-token "org..* *Test*" pattern that AnnotationMatcher uses. That only ever matched because of a TypeNameMatcher bug where a ..* token followed by a suffix matched every name, fixed upstream in #8012. Use a valid single-token glob org.junit..*Test* for the UsesType precondition; the AnnotationMatcher pattern is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven
KotlinTestMethodsShouldReturnUnitTesttests started failing with "Recipe was expected to make a change but made no changes."new UsesType<>("org..* *Test*", true).UsesTypematches against fully qualified type names, but"org..* *Test*"is the two-token<owner> <name>form thatAnnotationMatcher/MethodMatcherunderstand — no type name contains a space, so it could only ever match via theTypeNameMatcherbug where a..*token followed by a suffix matched every name. That bug was fixed upstream in FixTypeNameMatcher..*followed by a suffix matching every name rewrite#8012, which correctly tightened the matcher and exposed this latent issue.Uses a valid single-token glob
org.junit..*Test*for theUsesTypeprecondition, covering@Test,@ParameterizedTest,@RepeatedTest, and@TestTemplate. TheAnnotationMatcherpattern (which correctly supports the two-token form) is left unchanged.Validated locally with JDK 21 against the current rewrite snapshot:
KotlinTestMethodsShouldReturnUnitTestpasses (8/8), and the full./gradlew testis green (1599 tests, 0 failures).